From 8b610101bcf327c481f854c9bd33df9fe8245b3d Mon Sep 17 00:00:00 2001 From: LillyJadeKatrin Date: Tue, 22 Apr 2025 22:49:55 -0400 Subject: [PATCH] Fix memory bounds error in achievements dev This particular out of bounds error was causing every memory read at the far end of memory to return all zeroes. --- Source/Core/Core/AchievementManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index 01ed2b91a2..383b91c4d0 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -1316,7 +1316,7 @@ u32 AchievementManager::MemoryPeeker(u32 address, u8* buffer, u32 num_bytes, rc_ if (instance.m_dll_found) { std::lock_guard lg{instance.m_memory_lock}; - if (u64(address) + num_bytes >= instance.m_cloned_memory.size()) + if (u64(address) + num_bytes > instance.m_cloned_memory.size()) { ERROR_LOG_FMT(ACHIEVEMENTS, "Attempt to read past memory size: size {} address {} write length {}",