mirrors/dolphin-emulator
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-24 22:34:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #13565 from LillyJadeKatrin/retroachievements-end-of-memory-bug

Browse source 
Fix memory bounds error in achievements dev
This commit is contained in:
JMC47 2025-04-23 01:01:47 -04:00 • committed by GitHub
commit 8f3483fdd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/Core/AchievementManager.cpp
View file

@ -1318,7 +1318,7 @@ u32 AchievementManager::MemoryPeeker(u32 address, u8* buffer, u32 num_bytes, rc_
if (instance.m_dll_found) if (instance.m_dll_found)
{ {
std::lock_guard lg{instance.m_memory_lock}; std::lock_guard lg{instance.m_memory_lock};
if (u64(address) + num_bytes >= instance.m_cloned_memory.size()) if (u64(address) + num_bytes > instance.m_cloned_memory.size())
{ {
ERROR_LOG_FMT(ACHIEVEMENTS, ERROR_LOG_FMT(ACHIEVEMENTS,
"Attempt to read past memory size: size {} address {} write length {}", "Attempt to read past memory size: size {} address {} write length {}",