Merge pull request #13565 from LillyJadeKatrin/retroachievements-end-of-memory-bug

Fix memory bounds error in achievements dev
This commit is contained in:
JMC47 2025-04-23 01:01:47 -04:00 committed by GitHub
commit 8f3483fdd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1318,7 +1318,7 @@ u32 AchievementManager::MemoryPeeker(u32 address, u8* buffer, u32 num_bytes, rc_
if (instance.m_dll_found)
{
std::lock_guard lg{instance.m_memory_lock};
if (u64(address) + num_bytes >= instance.m_cloned_memory.size())
if (u64(address) + num_bytes > instance.m_cloned_memory.size())
{
ERROR_LOG_FMT(ACHIEVEMENTS,
"Attempt to read past memory size: size {} address {} write length {}",