linter: Add and apply new formatting rules

New rules:
`InsertNewlineAtEOF: true`
`RemoveSemicolon: true`
`RequiresClausePosition: WithPreceding`
This commit is contained in:
Joshua Vandaële 2025-04-23 11:19:14 +02:00
parent 2c54ee94c1
commit bf554edfe0
No known key found for this signature in database
GPG key ID: 5E8F4E7EDBD390EA
9 changed files with 20 additions and 18 deletions

View file

@ -54,6 +54,7 @@ IncludeCategories:
IndentCaseLabels: false IndentCaseLabels: false
IndentWidth: 2 IndentWidth: 2
IndentWrappedFunctionNames: false IndentWrappedFunctionNames: false
InsertNewlineAtEOF: true
KeepEmptyLinesAtTheStartOfBlocks: false KeepEmptyLinesAtTheStartOfBlocks: false
MacroBlockBegin: '' MacroBlockBegin: ''
MacroBlockEnd: '' MacroBlockEnd: ''
@ -67,6 +68,8 @@ PenaltyExcessCharacter: 1000000
PenaltyReturnTypeOnItsOwnLine: 60 PenaltyReturnTypeOnItsOwnLine: 60
PointerAlignment: Left PointerAlignment: Left
ReflowComments: true ReflowComments: true
RemoveSemicolon: true
RequiresClausePosition: WithPreceding
SortIncludes: true SortIncludes: true
SpaceAfterCStyleCast: false SpaceAfterCStyleCast: false
SpaceBeforeAssignmentOperators: true SpaceBeforeAssignmentOperators: true

View file

@ -18,7 +18,7 @@ namespace Config
// Setting a key to an object of this type will delete the key. // Setting a key to an object of this type will delete the key.
struct DefaultState struct DefaultState
{ {
friend constexpr bool operator==(DefaultState, DefaultState) { return true; }; friend constexpr bool operator==(DefaultState, DefaultState) { return true; }
}; };
namespace detail namespace detail

View file

@ -11,8 +11,7 @@ namespace Common
struct ContainsFn struct ContainsFn
{ {
template <std::input_iterator I, std::sentinel_for<I> S, class T, class Proj = std::identity> template <std::input_iterator I, std::sentinel_for<I> S, class T, class Proj = std::identity>
requires std::indirect_binary_predicate<std::ranges::equal_to, std::projected<I, Proj>, requires std::indirect_binary_predicate<std::ranges::equal_to, std::projected<I, Proj>, const T*>
const T*>
constexpr bool operator()(I first, S last, const T& value, Proj proj = {}) const constexpr bool operator()(I first, S last, const T& value, Proj proj = {}) const
{ {
return std::ranges::find(std::move(first), last, value, std::move(proj)) != last; return std::ranges::find(std::move(first), last, value, std::move(proj)) != last;

View file

@ -73,7 +73,7 @@ void TruncateToCString(std::string* s);
bool TryParse(const std::string& str, bool* output); bool TryParse(const std::string& str, bool* output);
template <typename T> template <typename T>
requires(std::is_integral_v<T> || (std::is_enum_v<T> && !detail::IsBooleanEnum<T>())) requires(std::is_integral_v<T> || (std::is_enum_v<T> && !detail::IsBooleanEnum<T>()))
bool TryParse(const std::string& str, T* output, int base = 0) bool TryParse(const std::string& str, T* output, int base = 0)
{ {
char* end_ptr = nullptr; char* end_ptr = nullptr;
@ -112,7 +112,7 @@ bool TryParse(const std::string& str, T* output, int base = 0)
} }
template <typename T> template <typename T>
requires(detail::IsBooleanEnum<T>()) requires(detail::IsBooleanEnum<T>())
bool TryParse(const std::string& str, T* output) bool TryParse(const std::string& str, T* output)
{ {
bool value; bool value;

View file

@ -171,8 +171,8 @@ public:
void SetDevMenuUpdateCallback(std::function<void(void)> callback) void SetDevMenuUpdateCallback(std::function<void(void)> callback)
{ {
m_dev_menu_callback = callback; m_dev_menu_callback = callback;
}; }
bool CheckForModifications() { return rc_client_raintegration_has_modifications(m_client); }; bool CheckForModifications() { return rc_client_raintegration_has_modifications(m_client); }
#endif // RC_CLIENT_SUPPORTS_RAINTEGRATION #endif // RC_CLIENT_SUPPORTS_RAINTEGRATION
void DoState(PointerWrap& p); void DoState(PointerWrap& p);
@ -339,13 +339,13 @@ public:
u16 revision) u16 revision)
{ {
return true; return true;
}; }
constexpr bool CheckApprovedARCode(const ActionReplay::ARCode& code, const std::string& game_id, constexpr bool CheckApprovedARCode(const ActionReplay::ARCode& code, const std::string& game_id,
u16 revision) u16 revision)
{ {
return true; return true;
}; }
constexpr void LoadGame(const std::string&, const DiscIO::Volume*) {} constexpr void LoadGame(const std::string&, const DiscIO::Volume*) {}

View file

@ -23,7 +23,7 @@ protected:
bool ConnectInternal() override; bool ConnectInternal() override;
void DisconnectInternal() override; void DisconnectInternal() override;
bool IsConnected() const override; bool IsConnected() const override;
void IOWakeup() override {}; void IOWakeup() override {}
int IORead(u8* buf) override; int IORead(u8* buf) override;
int IOWrite(u8 const* buf, size_t len) override; int IOWrite(u8 const* buf, size_t len) override;

View file

@ -190,4 +190,4 @@ void ConfigComplexChoice::mousePressEvent(QMouseEvent* event)
{ {
QComboBox::mousePressEvent(event); QComboBox::mousePressEvent(event);
} }
}; }

View file

@ -90,7 +90,7 @@ protected:
return Config::Get(setting); return Config::Get(setting);
} }
virtual void OnConfigChanged() {}; virtual void OnConfigChanged() {}
private: private:
bool IsConfigLocal() const bool IsConfigLocal() const

View file

@ -57,7 +57,7 @@ public:
explicit StateTracker(); explicit StateTracker();
~StateTracker(); ~StateTracker();
Framebuffer* GetCurrentFramebuffer() { return m_current_framebuffer; }; Framebuffer* GetCurrentFramebuffer() { return m_current_framebuffer; }
void SetCurrentFramebuffer(Framebuffer* framebuffer); void SetCurrentFramebuffer(Framebuffer* framebuffer);
void BeginClearRenderPass(MTLClearColor color, float depth); void BeginClearRenderPass(MTLClearColor color, float depth);
void BeginRenderPass(MTLLoadAction load_action); void BeginRenderPass(MTLLoadAction load_action);