mirrors/dolphin-emulator
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-24 14:24:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Create IsTargetWithinTypeBounds function

Browse source
This commit is contained in:
Dr. Dystopia 2025-03-26 08:12:08 +01:00
parent 18979129f3
commit d5648cf2cb
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Source/Core/DolphinQt/FIFO/FIFOAnalyzer.cpp
View file

@ -323,6 +323,11 @@ public:
}; };
} // namespace } // namespace
template<typename T>
bool IsTargetWithinTypeBounds(u8 target) {
return target >= std::numeric_limits<T>::min() && target <= std::numeric_limits<T>::max();
}
void FIFOAnalyzer::UpdateDetails() void FIFOAnalyzer::UpdateDetails()
{ {
// Clearing the detail list can update the selection, which causes UpdateDescription to be called // Clearing the detail list can update the selection, which causes UpdateDescription to be called
@ -364,6 +369,7 @@ void FIFOAnalyzer::UpdateDetails()
while (object_offset < object_size) while (object_offset < object_size)
{ {
const u32 start_offset = object_offset; const u32 start_offset = object_offset;
ASSERT(IsTargetWithinTypeBounds<int>(start_offset));
m_object_data_offsets.push_back(start_offset); m_object_data_offsets.push_back(start_offset);
object_offset += OpcodeDecoder::RunCommand(&fifo_frame.fifoData[object_start + start_offset], object_offset += OpcodeDecoder::RunCommand(&fifo_frame.fifoData[object_start + start_offset],
@ -508,6 +514,10 @@ void FIFOAnalyzer::ShowSearchResult(size_t index)
const auto& result = m_search_results[index]; const auto& result = m_search_results[index];
ASSERT(IsTargetWithinTypeBounds<int>(result.m_frame));
ASSERT(IsTargetWithinTypeBounds<int>(result.m_object_idx));
ASSERT(IsTargetWithinTypeBounds<int>(result.m_cmd));
QTreeWidgetItem* object_item = QTreeWidgetItem* object_item =
m_tree_widget->topLevelItem(0)->child(result.m_frame)->child(result.m_object_idx); m_tree_widget->topLevelItem(0)->child(result.m_frame)->child(result.m_object_idx);