mirrors/dolphin-emulator
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-24 22:34:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

AudioPanel bugfix: Forgot to wrap an optional slider in a conditional.

Browse source
This commit is contained in:
TryTwo 2025-03-28 14:22:40 -07:00
parent e0032b3e2c
commit efd993f382
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Source/Core/DolphinQt/Settings/AudioPane.cpp
View file

@ -161,8 +161,12 @@ void AudioPane::ConnectWidgets()
m_volume_indicator->setText(tr("%1%").arg(value)); m_volume_indicator->setText(tr("%1%").arg(value));
AudioCommon::UpdateSoundStream(Core::System::GetInstance()); AudioCommon::UpdateSoundStream(Core::System::GetInstance());
}); });
connect(m_latency_slider, &QSlider::valueChanged, this,
[this](int value) { m_latency_label->setText(tr("Latency: %1 ms").arg(value)); }); if (m_latency_control_supported)
{
connect(m_latency_slider, &QSlider::valueChanged, this,
[this](int value) { m_latency_label->setText(tr("Latency: %1 ms").arg(value)); });
}
} }
void AudioPane::OnDspChanged() void AudioPane::OnDspChanged()
@ -242,9 +246,6 @@ void AudioPane::AddDescriptions()
static const char TR_AUDIO_BACKEND_DESCRIPTION[] = static const char TR_AUDIO_BACKEND_DESCRIPTION[] =
QT_TR_NOOP("Selects which audio API to use internally.<br><br><dolphin_emphasis>If unsure, " QT_TR_NOOP("Selects which audio API to use internally.<br><br><dolphin_emphasis>If unsure, "
"select %1.</dolphin_emphasis>"); "select %1.</dolphin_emphasis>");
static const char TR_WASAPI_DEVICE_DESCRIPTION[] =
QT_TR_NOOP("Selects an output device to use.<br><br><dolphin_emphasis>If unsure, select "
"Default Device.</dolphin_emphasis>");
static const char TR_LATENCY_SLIDER_DESCRIPTION[] = QT_TR_NOOP( static const char TR_LATENCY_SLIDER_DESCRIPTION[] = QT_TR_NOOP(
"Sets the audio latency in milliseconds. Higher values may reduce audio crackling. Certain " "Sets the audio latency in milliseconds. Higher values may reduce audio crackling. Certain "
"backends only.<br><br><dolphin_emphasis>If unsure, leave this at 20 ms.</dolphin_emphasis>"); "backends only.<br><br><dolphin_emphasis>If unsure, leave this at 20 ms.</dolphin_emphasis>");
@ -279,9 +280,13 @@ void AudioPane::AddDescriptions()
m_dolby_quality_combo->SetDescription(tr(TR_DOLBY_OPTIONS_DESCRIPTION)); m_dolby_quality_combo->SetDescription(tr(TR_DOLBY_OPTIONS_DESCRIPTION));
#ifdef _WIN32 #ifdef _WIN32
static const char TR_WASAPI_DEVICE_DESCRIPTION[] =
QT_TR_NOOP("Selects an output device to use.<br><br><dolphin_emphasis>If unsure, select "
"Default Device.</dolphin_emphasis>");
m_wasapi_device_combo->SetTitle(tr("Output Device")); m_wasapi_device_combo->SetTitle(tr("Output Device"));
m_wasapi_device_combo->SetDescription(tr(TR_WASAPI_DEVICE_DESCRIPTION)); m_wasapi_device_combo->SetDescription(tr(TR_WASAPI_DEVICE_DESCRIPTION));
#endif #endif
m_volume_slider->SetTitle(tr("Volume")); m_volume_slider->SetTitle(tr("Volume"));
m_volume_slider->SetDescription(tr(TR_VOLUME_DESCRIPTION)); m_volume_slider->SetDescription(tr(TR_VOLUME_DESCRIPTION));