Pierre Bourdon
9da8593cf4
Merge pull request #3569 from mathieui/netplay-gcpad-position
...
[netplay] Fix a regression
2016-01-30 11:54:31 +01:00
Pierre Bourdon
ff5d6887d1
Merge pull request #3575 from mathieui/netplay-server-cleanup
...
Small netplay server cleanup & fix
2016-01-30 11:51:50 +01:00
mathieui
c7750b287d
netplay: default the local pad to a gc controller
...
if the configured local pad is none, it will make dolphin behave
incorrectly (due to the game expecting inputs from the device while it
doesn’t exist).
2016-01-28 20:24:18 +01:00
mathieui
4529930f91
gcadapter: fix an incorrect mapping for non-local devices
...
Remote devices would always enter an error path and get disconnected
from the gamecube, breaking netplay in the process.
Culprit is still InGamePadToLocalPad
2016-01-28 02:46:58 +01:00
mathieui
b9b4a0c530
gcadapter: set the konga setting properly
...
if it was used in netplay, it would read memory out of bounds
(due to the mapping method returning 4 if the device was remote) which
was 0 more often than not, causing the device in this position to be a konga.
(which may or not be the gcadapter due to the swap between local and
ingame controllers)
2016-01-28 02:39:55 +01:00
degasus
a4a2928905
FifoPlayer: Sleep while high watermark is set.
2016-01-27 07:23:17 +01:00
mathieui
aaf2be2044
bootmanager: update the supposed-end-of-enum
...
fixes a bug where gcadapter would fuck up netplay
2016-01-27 01:43:38 +01:00
mathieui
24cb6487d4
[netplay] Fix a regression
...
Introduced in 6e13496d8
, pads would get assigned to their netplay
position, which breaks assumptions. With this behavior, the SI devices
should be mapped properly.
2016-01-27 01:43:31 +01:00
mathieui
8ce9191948
NetPlayServer: Make SendAsyncToClients use an unique_ptr
2016-01-27 01:34:03 +01:00
mathieui
34ae512d91
NetPlayServer: Make pad data unpacking nicer to read
2016-01-27 01:34:03 +01:00
mathieui
1c808a2835
NetPlayServer: Possible out-of-bounds access on invalid input
...
if a pad or wiimote number was outside bounds (e.g. 42353543232),
it would still have been read from the array, which could lead to
inappropriate consequences, like a segfault.
2016-01-27 01:33:50 +01:00
mathieui
8e1be37feb
NetPlayServer: in-class initialization
2016-01-27 01:20:44 +01:00
degasus
159d83c5a9
FifoPlayer: Use more enums.
2016-01-26 19:19:21 +01:00
Mathew Maidment
48e7e5b72e
Merge pull request #3567 from lioncash/netplay
...
NetPlayClient: Minor changes
2016-01-25 05:13:54 -05:00
Mathew Maidment
ee0fbdf087
Merge pull request #3558 from lioncash/dvd-global
...
DVDInterface: Reduce a global variable to translation unit scope
2016-01-25 05:13:08 -05:00
Lioncash
c434b5b3a9
NetPlayClient: Use std::array instead of C arrays for buffers
2016-01-25 04:57:21 -05:00
Lioncash
7304c863a6
NetPlayClient: Deduplicate code for player list retrieval
2016-01-25 04:57:20 -05:00
Lioncash
e6ad76fa70
NetPlayClient: Extract control mapping checking to its own function
2016-01-25 04:57:19 -05:00
Lioncash
8588c8fd31
NetPlayClient: Make SendAsync take a unique_ptr as a parameter
2016-01-25 04:57:18 -05:00
Lioncash
c2deb337aa
NetPlayClient: In-class initialize variables where possible
2016-01-25 04:57:17 -05:00
Lioncash
1d8ff504a5
NetPlayClient: Make m_state private
...
Also turns it into an enum class.
2016-01-25 04:57:16 -05:00
Lioncash
102672a797
NetPlayClient: Make is_connected private
...
This is only queried, there's no need to expose it for writing.
Even if it was written to, a data member shouldn't be part of
your public API unless its part of a dumb object or trivial struct.
2016-01-25 04:57:04 -05:00
Lioncash
d9f87b8030
NetPlayClient: Remove unnecessary includes
...
Replace with needed ones
2016-01-24 21:46:49 -05:00
Lioncash
90f2f48ef6
DVDInterface: Use correct prefix for static local variables
2016-01-24 17:24:33 -05:00
degasus
4295751662
Fifo: More comments for SyncGPU functions.
2016-01-24 11:06:01 +01:00
degasus
cf4478dc92
Fifo: Fix SyncGPU.
...
CBoot::BootUp() did call CoreTiming::Advance which itself blocks on the GPU,
but the GPU thread wasn't started already. This commit moves the SyncGPU
initialization into the Fifo.cpp file and call it after BootUp().
2016-01-24 11:06:01 +01:00
Lioncash
a2dc22f016
DVDInterface: Make a global a local variable
2016-01-23 18:40:55 -05:00
mathieui
5e709f3d72
[netplay] Use the local type of each SI device
...
Instead of using SI_GCcontroller which would make it not work with gc
adapters, bongos, and other stuff.
Trying to fix issue #9263
2016-01-23 17:29:07 +01:00
Ryan Houdek
ae4c7661d6
Merge pull request #3212 from mickdermack/pr-recalc-flags
...
JIT x64: Recalculate flags after add/sub
2016-01-22 12:45:52 -05:00
Lioncash
fdf6fb47e0
VideoInterface: specify internal linkage on local variable
2016-01-21 19:25:21 -05:00
Ryan Houdek
7c3e4b34f3
Merge pull request #3541 from Sonicadvance1/fix_netplay_option_sending
...
Stops netplay clients from failing to send settings on game start
2016-01-21 08:51:11 -05:00
Ryan Houdek
1a20772ccd
Stops netplay clients from failing to send settings on game start
...
Clients have no need to send their configuration information on start and the server straight out ignores it.
Not to mention it shouldn't try sending a struct as a null terminated string.
Cleans up how the server sends the configuration slightly as well.
2016-01-21 07:20:21 -06:00
Lioncash
82147f42af
VideoInterface: Correct namespace indentation
2016-01-21 00:40:01 -05:00
Lioncash
f45e1bff37
VideoInterface: Change a global into a translation-unit local variable
2016-01-21 00:39:24 -05:00
Pierre Bourdon
e455ca4d58
Merge pull request #3535 from RisingFog/cya_savestate_memleak
...
Properly clear JIT cache on save states
2016-01-20 18:02:25 +01:00
Chris Burgener
a7a744d33c
Properly clear JIT cache on save states
2016-01-20 11:20:15 -05:00
Lioncash
42e9927bca
VideoInterface: Fix code style/indentation
2016-01-19 20:16:18 -05:00
Pierre Bourdon
991d3f6f96
Merge pull request #3525 from lioncash/ptr
...
DSPEmulator: Make CreateDSPEmulator return a unique_ptr
2016-01-19 23:54:58 +01:00
Ryan Houdek
7b9eeba168
Merge pull request #3479 from Sonicadvance1/fix_hotkeys
...
Fix hotkeys not reporting inputs.
2016-01-19 02:15:25 -05:00
Ryan Houdek
f73961663e
Fix a typo on the size passed in to the IPL descrambler.
...
Fixes issue #6081
2016-01-18 04:30:30 -06:00
Lioncash
2ff5923334
DSPEmulator: Make CreateDSPEmulator return a unique_ptr
2016-01-17 22:33:21 -05:00
Lioncash
d9fec92628
VideoCommon: Header cleanup
...
Also remedies places where the video backends and core rely on things
being indirectly included.
2016-01-17 20:11:45 -05:00
Mathew Maidment
87464d432b
Merge pull request #3501 from rohit-n/build-pch
...
Fix building with PCH disabled.
2016-01-13 21:07:51 -05:00
Lioncash
f2038b9e90
HW: Remove unnecessary header inclusions
2016-01-13 02:47:32 -05:00
Pierre Bourdon
8f8134f5f4
Merge pull request #3504 from degasus/master
...
VideoBackend: Cleanup API a bit.
2016-01-13 01:27:24 +01:00
degasus
5f244abf28
Fifo: Create a "Fifo" namespace.
2016-01-12 23:28:26 +01:00
degasus
c3481a576b
VideoBackend: Remove simple wrapper functions.
2016-01-12 23:28:26 +01:00
degasus
0c92603fd5
Merge VideoBackendHardware into VideoBackend.
...
And rename it to VideoBackendBase because of conflicts within the backends itself.
2016-01-12 23:18:58 +01:00
Lioncash
f8fcceb99e
Jit: Get rid of indirect includes
2016-01-12 00:12:36 -05:00
Rohit Nirmal
f9837d4447
Fix building with PCH disabled.
2016-01-11 13:20:47 -06:00