dolphin-emulator/Source/Core/InputCommon
JosJuice 6cf55ab1ee InputCommon: Unify GetProfileName and GetProfileDirectoryName
After reading the previous commit, you might think "hold on, what's the
difference between GetProfileName and GetProfileDirectoryName"? These
two are being used for the exact same thing - figuring out where
profiles are stored - yet they return different values for certain
controllers like GC keyboards! As far as I can tell, the existing code
has been broken for GC keyboards since they were introduced a decade
ago. The GUI (and more recently, also InputCycler) would write and read
profiles in one location, and our code for loading profiles specified in
a game INI file would read profiles in another location.

This commit gets rid of the set of values used by the game INI code in
favor of the other set. This does breaking existing setups where a
GCKey profile has been configured in a game INI, but I think the number
of working such setups is vanishingly small. The alternative would make
existing GCKey profiles go missing from the profile dropdown in the GUI,
which I think would be more disruptive. The alternative would also force
new GCKey profiles into the same directory as GCPad profiles.

This commit also fixes a regression from d6c0f8e749. The Android GUI was
using GetProfileName to figure out what key to use in the game INI,
which made it use incorrect game INI entries for GameCube controller
profiles but not Wii Remote profiles. Now the Android GUI uses
GetProfileKey for this, fixing the problem.
2024-02-04 17:55:08 +01:00
..
ControllerEmu Android: Get profile name from core 2023-10-01 18:47:49 +02:00
ControllerInterface InputCommon/WGInput: Handle add/remove events on separate thread to prevent deadlocks. 2024-01-18 00:30:45 +01:00
ControlReference Merge pull request #12399 from lioncash/erasing 2023-12-12 20:54:52 +00:00
DynamicInputTextures DITConfiguration: Use File::ReadFileToString 2023-06-17 19:38:15 -05:00
CMakeLists.txt CMake: Use targets for all optionally-external dependencies 2023-06-15 01:41:41 -05:00
DynamicInputTextureManager.cpp InputCommon / VideoCommon: remove dynamic input reloading the texture cache, this is no longer needed, assets reload automatically! 2023-06-07 18:30:10 -05:00
DynamicInputTextureManager.h Common/IniFile: Move interface into Common namespace 2023-04-13 10:19:28 -04:00
GCAdapter.cpp Core/SystemTimers: Refactor to class, move to System. 2024-01-04 23:35:19 +01:00
GCAdapter.h GCAdapter: Process pad state in read thread and other general cleanups. 2022-10-22 00:38:59 -05:00
GCPadStatus.h Fix all uninitialized variable warnings (C26495) 2021-10-13 12:32:16 -07:00
ImageOperations.cpp Add option for setting the PNG zlib compression level 2021-11-18 13:10:22 -08:00
ImageOperations.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
InputConfig.cpp InputCommon: Unify GetProfileName and GetProfileDirectoryName 2024-02-04 17:55:08 +01:00
InputConfig.h InputCommon: Unify GetProfileName and GetProfileDirectoryName 2024-02-04 17:55:08 +01:00
InputProfile.cpp InputCommon: Unify GetProfileName and GetProfileDirectoryName 2024-02-04 17:55:08 +01:00
InputProfile.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
KeyboardStatus.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00