JosJuice 72cf2bdb87 Audit uses of IsRunning and GetState ... Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed.		2024-06-21 20:52:55 +02:00
..
Achievements	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
Config	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
Debugger	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
FIFO	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
GameList	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
InfinityBase	DolphinQt: Fix double argument in Infinity error message	2024-05-19 21:52:49 +02:00
NetPlay	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
QtUtils	PPCSymbolDB: GetDescription by std::string_view	2024-04-13 00:19:01 -07:00
Settings	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
SkylanderPortal	Change Default Skylander File Selection Types	2024-05-17 02:52:50 +01:00
Styles/Dark	Dark style: add QTableCornerButton. Fix padding for tables.	2023-11-04 15:00:07 -07:00
TAS	Core::IsRunning: Avoid Global System Accessor	2024-05-01 08:54:17 -07:00
AboutDialog.cpp	DolphinQt: Update AboutDialog to include number of commits ahead of master.	2024-03-23 16:48:52 -05:00
AboutDialog.h
CheatSearchFactoryWidget.cpp	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
CheatSearchFactoryWidget.h
CheatSearchWidget.cpp	DolphinQt: Properly Delete (Some) Widgets	2024-04-30 11:17:28 -07:00
CheatSearchWidget.h	DolphinQt: Allow Cheat Search to create multiple AR codes when selecting multiple lines.	2024-03-17 01:29:39 -05:00
CheatsManager.cpp	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
CheatsManager.h	CheatsManager/CheatSearchWidget: Avoid Global System Accessor	2024-03-11 20:51:15 -07:00
CMakeLists.txt	Merge pull request #12728 from OatmealDome/mac-version-numbers-2	2024-05-30 01:13:32 -04:00
ConvertDialog.cpp	DolphinQt: Remove unnecessary qOverloads	2023-11-04 14:14:14 -07:00
ConvertDialog.h
DiscordHandler.cpp	DolphinQt: Set window decorations for all top-level QWidgets.	2023-08-12 16:54:54 +02:00
DiscordHandler.h
DiscordJoinRequestDialog.cpp
DiscordJoinRequestDialog.h
DolphinEmu.entitlements
DolphinEmuDebug.entitlements
DolphinQt.manifest
DolphinQt.rc
DolphinQt.vcxproj	Created AchievementBox Qt object	2024-05-01 06:43:20 -04:00
DolphinQt.vcxproj.user
GBAHost.cpp
GBAHost.h
GBAWidget.cpp	Core::RunOnCPUThread: Avoid Global System Accessor	2024-03-28 10:10:03 -07:00
GBAWidget.h	GBAWidget: Add missing override specifiers	2023-12-13 10:12:18 -05:00
GCMemcardCreateNewDialog.cpp
GCMemcardCreateNewDialog.h
GCMemcardManager.cpp	DolphinQt: Set window decorations for all top-level QWidgets.	2023-08-12 16:54:54 +02:00
GCMemcardManager.h	GCMemcardManager: Shorten-up EnumMap definitions	2023-06-08 13:05:13 -04:00
Host.cpp	Core::GetState: Avoid Global System Accessor	2024-04-08 16:23:23 -07:00
Host.h	DolphinQt: A Ubiquitous Signal For When Symbols Change	2024-03-28 09:57:22 -07:00
HotkeyScheduler.cpp	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
HotkeyScheduler.h
Info.plist.in
Main.cpp	Core: Remove RunAsCPUThread	2024-03-23 03:33:26 -07:00
MainWindow.cpp	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
MainWindow.h	Merge pull request #11497 from vyuuui/debugger_assembler_ui	2023-12-16 21:15:31 +00:00
MenuBar.cpp	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
MenuBar.h	Audit uses of IsRunning and GetState	2024-06-21 20:52:55 +02:00
NANDRepairDialog.cpp
NANDRepairDialog.h
NKitWarningDialog.cpp	DolphinQt: Set window decorations for all top-level QWidgets.	2023-08-12 16:54:54 +02:00
NKitWarningDialog.h
pch_qt.cpp
pch_qt.h
qt.conf
qt.conf.win
qt6.natvis
RenderWidget.cpp	Core: Store current state in less places	2024-06-21 20:46:44 +02:00
RenderWidget.h	Remove rounded corners on emulation render window	2024-04-28 12:41:39 +03:00
resource.h
ResourcePackManager.cpp	DolphinQt: Set window decorations for all top-level QWidgets.	2023-08-12 16:54:54 +02:00
ResourcePackManager.h
Resources.cpp
Resources.h
RiivolutionBootWidget.cpp	Disable memory patches in hardcore mode	2023-12-02 16:41:16 -05:00
RiivolutionBootWidget.h	Disable memory patches in hardcore mode	2023-12-02 16:41:16 -05:00
SearchBar.cpp
SearchBar.h
Settings.cpp	Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined	2024-06-06 08:26:20 +02:00
Settings.h	InterfacePane: Add BalloonTip to cursor visible radio buttons	2024-05-31 19:09:00 +02:00
ToolBar.cpp	Core::GetState: Avoid Global System Accessor	2024-04-08 16:23:23 -07:00
ToolBar.h
Translation.cpp
Translation.h
Updater.cpp	DolphinQt: Properly Delete (Some) Widgets	2024-04-30 11:17:28 -07:00
Updater.h
WiiUpdate.cpp	DolphinQt: Set window decorations for all top-level QWidgets.	2023-08-12 16:54:54 +02:00
WiiUpdate.h