mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-04-24 14:24:54 +00:00
bda1f379b7
I've been playing Rock Band 3 recently and have experienced a bug where sometimes if you disconnect and reconnect a USB microphone, the game won't pick up on it connecting, not even it you disconnect and reconnect it again. An investigation into what's going on inside Dolphin shows that when the game triggers a call to OH0::DeviceOpen after the device has been reinserted, Dolphin doesn't open the device because it's already present in m_opened_devices. Removing the device from m_opened_devices after calling OH0::TriggerHook in OH0::OnDeviceChange resolves this specific issue in my testing. Doing this matches us removing the device from m_opened_devices after calling OH0::TriggerHook in OH0::DeviceClose, but I haven't looked at exactly what real IOS does. I have been able to reproduce a much rarer issue that has the same symptoms on the surface but where OH0::DeviceOpen gets past its m_opened_devices check. I'm currently not sure what the cause of this remaining issue is. |
||
|---|---|---|
| .. | ||
| Android | ||
| Core | ||
| DSPSpy | ||
| DSPTool | ||
| PCH | ||
| UnitTests | ||
| VSProps | ||
| .clang-format | ||
| CMakeLists.txt | ||
| dolphin-emu.sln | ||