mirrors/dolphin-emulator
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-19 16:21:50 +00:00
Code Issues Projects Releases Packages Wiki Activity
dolphin-emulator/Source/Core/Core
History
Phil Christensen 2ed61b0ee1 C++ conformance fixes (MSVC /permissive-) 
We (the Microsoft C++ team) use the dolphin project as part of our "Real world code" tests.
I noticed a few issues in windows specific code when building dolphin with the MSVC compiler
in its conformance mode (/permissive-).  For more information on /permissive- see our blog
https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/.

These changes are to address 3 different types of issues:

1) Use of qualified names in member declarations

    struct A {
        void A::f() { } // error C4596: illegal qualified name in member declaration
                        // remove redundant 'A::' to fix
    };

2) Binding a non-const reference to a temporary

    struct S{};
  
    // If arg is in 'in' parameter, then it should be made const.
    void func(S& arg){}
  
    int main() {
      //error C2664: 'void func(S &)': cannot convert argument 1 from 'S' to 'S &'
      //note: A non-const reference may only be bound to an lvalue
      func( S() );
   
      //Work around this by creating a local, and using it to call the function
      S s;
      func( s );
    }

3) Add missing #include <intrin.h>

Because of the workaround you are using in the code you will need to include
this.  This is because of changes in the libraries and not /permissive-
2017-02-15 20:37:04 -08:00
..
Boot Boot: Remove unused game ID string 2017-02-12 07:55:49 -05:00
Debugger Core: Convert State enum into an enum class 2017-02-05 08:32:23 -05:00
DSP DSPCore: Make g_cycles_left a regular member variable of DSPEmitter 2017-02-07 21:56:57 -05:00
FifoPlayer OpcodeDecoding: Convert #defines into enum constants 2017-02-08 00:05:17 -05:00
HLE Merge pull request #4817 from sepalani/debug_print_case 2017-02-06 17:40:44 +13:00
HW C++ conformance fixes (MSVC /permissive-) 2017-02-15 20:37:04 -08:00
IOS Merge pull request #4907 from leoetlino/ios-constants 2017-02-15 21:09:42 +01:00
PowerPC Merge pull request #4862 from lioncash/compile 2017-02-15 11:44:37 -05:00
ActionReplay.cpp specify custom brace style to fix unions 2017-01-05 12:55:13 +01:00
ActionReplay.h CheatManager/ISOProperties: Refactor ActionReplay tabs as a class 2016-08-31 14:32:12 +10:00
Analytics.cpp ControllerEmu: Separate ControlGroup from ControllerEmu 2017-02-09 18:18:52 -05:00
Analytics.h ControllerEmu: Separate ControlGroup from ControllerEmu 2017-02-09 18:18:52 -05:00
ARDecrypt.cpp CheatManager/ISOProperties: Refactor ActionReplay tabs as a class 2016-08-31 14:32:12 +10:00
ARDecrypt.h CheatManager/ISOProperties: Refactor ActionReplay tabs as a class 2016-08-31 14:32:12 +10:00
BootManager.cpp Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
BootManager.h Don't read/store settings directly from/to SYSCONF 2016-10-08 14:37:55 +02:00
CMakeLists.txt IOS: Separate net/kd code out from Net.cpp 2017-02-11 23:09:08 -05:00
ConfigManager.cpp Merge pull request #4408 from leoetlino/usb 2017-02-07 09:17:05 +13:00
ConfigManager.h IOS: Implement MIOS functionality 2017-02-08 15:07:34 +01:00
Core.cpp Fix connecting Wii remotes on boot 2017-02-11 08:58:47 +01:00
Core.h Core: Actually make the State enum an enum class 2017-02-06 01:13:07 -05:00
Core.vcxproj Merge pull request #4862 from lioncash/compile 2017-02-15 11:44:37 -05:00
Core.vcxproj.filters Merge pull request #4862 from lioncash/compile 2017-02-15 11:44:37 -05:00
CoreTiming.cpp Adjust event times after a PPC clock change 2017-02-08 16:22:27 +01:00
CoreTiming.h Adjust event times after a PPC clock change 2017-02-08 16:22:27 +01:00
DSPEmulator.cpp DSP: Namespace remaining un-namespaced DSP code 2016-12-31 17:20:14 -05:00
DSPEmulator.h DSPEmulator: Amend variable casing 2017-01-18 12:20:13 -05:00
ec_wii.cpp ec_wii: Make default data constexpr 2017-01-28 18:46:15 -05:00
ec_wii.h ec_wii: Amend function casing 2017-01-28 18:46:14 -05:00
GeckoCode.cpp GeckoCode: Provide operator== and operator!= overloads 2016-10-03 02:32:43 -04:00
GeckoCode.h GeckoCode: Provide operator== and operator!= overloads 2016-10-03 02:32:43 -04:00
GeckoCodeConfig.cpp Fix building with PCH disabled. 2016-08-07 01:18:59 -05:00
GeckoCodeConfig.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Host.h Host: Remove the Host_RequestFullscreen() method. 2016-11-11 20:36:09 +01:00
HotkeyManager.cpp ControllerEmu: Separate ControlGroup from ControllerEmu 2017-02-09 18:18:52 -05:00
HotkeyManager.h ControllerEmu: Separate ControlGroup from ControllerEmu 2017-02-09 18:18:52 -05:00
MachineContext.h Add a context definition for OpenBSD amd64. 2016-07-17 22:15:14 -06:00
MemoryWatcher.cpp Core: Change CoreTiming event key from int to EventType* 2016-09-03 14:55:44 +10:00
MemoryWatcher.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
MemTools.cpp Add a context definition for OpenBSD amd64. 2016-07-17 22:15:14 -06:00
MemTools.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Movie.cpp Movie: replace magic number 8 with sizeof(ControllerState) 2017-02-09 15:07:47 -08:00
Movie.h Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
NetPlayClient.cpp Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
NetPlayClient.h HW: Change u8 pad specifier params to int where applicable 2016-10-07 08:14:12 -04:00
NetPlayProto.h Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
NetPlayServer.cpp Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
NetPlayServer.h Fix bogus UPnP requests 2016-07-23 20:04:07 +02:00
PatchEngine.cpp MMU/PatchEngine: Fix potential crash during stack probe 2017-01-24 08:05:11 +11:00
PatchEngine.h PatchEngine: Get rid of a global variable 2017-01-03 18:59:33 -05:00
State.cpp IOS: Implement MIOS functionality 2017-02-08 15:07:34 +01:00
State.h DolphinWX: Don't translate OSD messages 2016-08-10 18:18:25 +02:00
WiiRoot.cpp Copy Wii save for current game for Netplay and TAS 2017-02-05 13:17:05 -05:00
WiiRoot.h Remove pre-generated SYSCONF 2017-01-12 21:30:11 +01:00