mastodon/db/migrate/20180310000000_change_columns_in_notifications_nonnullable.rb

class ChangeColumnsInNotificationsNonnullable < ActiveRecord::Migration[5.1]
  def change
    safety_assured do
      change_column_null :notifications, :activity_id, false
      change_column_null :notifications, :activity_type, false
      change_column_null :notifications, :account_id, false
      change_column_null :notifications, :from_account_id, false
    end
  end
end
Change columns in notifications nonnullable (#6764) 2018-03-24 20:51:28 +09:00			`class ChangeColumnsInNotificationsNonnullable < ActiveRecord::Migration[5.1]`
			`def change`
Fix old migrations failing because of strong_migrations update (#12692) Fixes #12690 The `strong_migrations` update from ba2eac8824a85aa9541f8070ed7bcd22b9982cc8 introduced a check for `change_column_null` specific to Postgres. This rejects old migrations. This commit just wraps old migrations with `safety_assured` to bypass this check. Alternatives would have been to: - Disable that check entirely (a possibility added in that same `strong_migrations` version) for Mastodon, but it makes sense to write new migrations without such a strong lock. - Rewrite the old migrations to do it in a way that do not require an exclusive lock. I thought fixing those old migrations for performance wasn't worth the pain. Also, if I understand correctly, the next version of `strong_migrations` is going to include a helper to do that. We could update those migrations at that point. 2019-12-29 05:39:08 +01:00			`safety_assured do`
			`change_column_null :notifications, :activity_id, false`
			`change_column_null :notifications, :activity_type, false`
			`change_column_null :notifications, :account_id, false`
			`change_column_null :notifications, :from_account_id, false`
			`end`
Change columns in notifications nonnullable (#6764) 2018-03-24 20:51:28 +09:00			`end`
			`end`